Adam Litke has posted comments on this change.
Change subject: fix circularr reference of storage pool ......................................................................
Patch Set 1: I would prefer that you didn't submit this
(2 inline comments)
Thanks for the patch! Please add some additional comments and improve the commit message as I suggest in the embedded comments.
.................................................... Commit Message Line 11: Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de In this commit message, please explain why your change fixes the problem. It should be clear to the patch reviewer what you are changing. To me, it is not obvious why changing the pool upgrade callback would fix the problem.
.................................................... File vdsm/storage/task.py Line 321: del self.cmd Please add a comment to explain why an explicit del is required.
-- To view, visit http://gerrit.ovirt.org/3242 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: Ie2993b0ad8d85898ca86008f7056973ff493e8de Gerrit-PatchSet: 1 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Royce Lv lvroyce@linux.vnet.ibm.com Gerrit-Reviewer: Adam Litke agl@us.ibm.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Eduardo ewarszaw@redhat.com Gerrit-Reviewer: Mark Wu wudxw@linux.vnet.ibm.com Gerrit-Reviewer: Saggi Mizrahi smizrahi@redhat.com