Yaniv Bronhaim has posted comments on this change.
Change subject: vdsm-tool: vdsm-id: add force option to force generate id
......................................................................
Patch Set 6:
(1 comment)
....................................................
File lib/vdsm/utils.py
Line 624:
Line 625: if p.returncode == 0 and 'Not' not in out:
Line 626: #Avoid error string - 'Not Settable' or 'Not
Present'
Line 627: __hostUUID = out.strip()
Line 628: elif force:
first, please explain this in the commit message
second, for other archs as ppc you should have specific code base (already done in
http://gerrit.ovirt.org/#/c/19395/ so use that), the use of dmidecode should use the
dmidecode_util.py and not explicit as now.
third, also appropriate solution for nested visualization instead of relying on uuid
package
fourth - you have to have something depends of the machine that should be much more unique
than using uuid package
and last, when you have specific solution for archs and nested virt, why would you need
force in any flow?
Line 629: hostid = str(uuid.uuid4())
Line 630: with open(constants.P_VDSM_NODE_ID, 'w') as f:
Line 631: f.write("%s\n", hostid)
Line 632: ovirtNodePersist([constants.P_VDSM_NODE_ID])
--
To view, visit
http://gerrit.ovirt.org/20808
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I89f1e29c9cdad0cadb32545fa27c1702ad2e116a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Alon Bar-Lev <alonbl(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes