Yaniv Bronhaim has posted comments on this change.
Change subject: configurator: move usermod to spec
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.ovirt.org/#/c/26055/1/vdsm.spec.in
File vdsm.spec.in:
Line 689: /usr/bin/getent passwd %{vdsm_user} >/dev/null || \
Line 690: /usr/sbin/useradd -r -u 36 -g %{vdsm_group} -d /var/lib/vdsm \
Line 691: -s /sbin/nologin -c "Node Virtualization Manager"
%{vdsm_user}
Line 692: /usr/sbin/usermod -a -G %{qemu_group},%{snlk_group} %{vdsm_user}
Line 693: /usr/sbin/usermod -a -G %{qemu_group},%{vdsm_group} %{snlk_user}
why not to call vdsm-tool configure --module sanlock ?
Line 694:
Line 695: %post
Line 696: %{_bindir}/vdsm-tool sebool-config || :
Line 697: # set the vdsm "secret" password for libvirt
Line 733: /bin/systemctl daemon-reload >/dev/null 2>&1 || :
Line 734: exit 0
Line 735: %endif
Line 736:
Line 737: %preun
These should happen on %posun, after all files with this ownership
are remo
again, do remove-config verb in vdsm-tool for sanlock module. much nicer
imo
Line 738: /usr/bin/gpasswd -d %{snlk_user} %{qemu_group}
Line 739: /usr/bin/gpasswd -d %{snlk_user} %{vdsm_group}
Line 740:
Line 741: if [ "$1" -eq 0 ]; then
--
To view, visit
http://gerrit.ovirt.org/26055
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I668552fa037414e9a6aee5b049d61749268f85d0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Fabian Deutsch <fabiand(a)fedoraproject.org>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes