mooli tayer has posted comments on this change.
Change subject: libvirtconnection: ping libvirt upon disconnection
......................................................................
Patch Set 5:
(2 comments)
....................................................
File lib/vdsm/libvirtconnection.py
Line 89: libvirt.VIR_ERR_INTERNAL_ERROR,
Line 90: libvirt.VIR_ERR_NO_CONNECT,
Line 91: libvirt.VIR_ERR_INVALID_CONN)
Line 92: if edom in EDOMAINS and ecode in ECODES:
Line 93: if _pingLibvirt:
what if libvirt is down and gitLibVersion is called? we won't catch the error.
From the users perspective i'm concerned that in all other cases
he gets one behavior and in gitLibVersion another and he knows nothing about it.
Line 94: conn = __connections.get(id(target))
Line 95: conn.getLibVersion(_pingLibvirt=False)
Line 96: else:
Line 97: log.error('connection to libvirt broken.'
....................................................
File tests/libvirtconnectionTests.py
Line 46: def get_error_domain(self):
Line 47: return LibvirtMock.VIR_FROM_RPC
Line 48:
Line 49: def get_error_level(self):
Line 50: return 3
Nope, unrelated, this is just some log level. I'll add a variable for it to prevent
confusion.
Line 51:
Line 52: def get_error_message(self):
Line 53: return ''
Line 54:
--
To view, visit
http://gerrit.ovirt.org/19444
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia489e46dd8ce4c70c888988d17b86311d3c4b935
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: mooli tayer <mtayer(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes