Ayal Baron has posted comments on this change.
Change subject: API: getAllTasks{Info|Statuses} does not return all tasks
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(3 inline comments)
....................................................
File vdsm/BindingXMLRPC.py
Line 659: tag = None
I don't understand the need for this "if". If nothing was passed, tag would
be "spm"...?
Line 666: tag = None
Same as above.
....................................................
File vdsm_cli/vdsClient.py
Line 1107: tag = ''
If we do not support passing None in xmlrpc then in the if above you can create a partial
object bound to tag args[0] and that way avoid passing anything in case there is such
param.
--
To view, visit
http://gerrit.ovirt.org/3613
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>