Saggi Mizrahi has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType' and MIXED_DEV
......................................................................
Patch Set 6:
(3 comments)
Also:
* multiple changes in one commit
* storageConstants is as bad as regular constants.
There is no need for sd and multipath to have the same
numbers. It breaks encapsulation for no apparent reason.
....................................................
Commit Message
Line 3: AuthorDate: 2013-03-27 16:01:51 +0200
Line 4: Commit: Yeela Kaplan <ykaplan(a)redhat.com>
Line 5: CommitDate: 2013-04-25 16:46:41 +0300
Line 6:
Line 7: multipath: Remove unused 'deduceType' and MIXED_DEV
It's not unused. You are just removing it.
Confused the hell out of me.
Line 8:
Line 9: a vg with mixed devices(of types iscsi and fcp) is not
Line 10: supported and is treated by default as an iscsi device.
Line 11:
....................................................
File vdsm/storage/hsm.py
Line 1852: 'pathstatus': dev.get("paths",
[]),
Line 1853: 'pathlist': dev.get("connections",
[]),
Line 1854: 'logicalblocksize':
dev.get("logicalblocksize", ""),
Line 1855: 'physicalblocksize':
dev.get("physicalblocksize", ""
Line 1856: )}
This bracket seem to have escaped
Line 1857: for path in devInfo["pathstatus"]:
Line 1858: if 'hbtl' in path:
Line 1859: path["lun"] = path["hbtl"].lun
Line 1860: del path["hbtl"]
....................................................
File vdsm/storage/multipath.py
Line 324:
Line 325: pathInfo["devnum"] =
DeviceNumber(*devicemapper.getDevNum(slave))
Line 326:
Line 327: if iscsi.devIsiSCSI(slave):
Line 328: devtypes.update(DEV_ISCSI)
s.update(1)
TypeError: 'int' object is not iterable
This shows you never tested this
Also:
devInfo["devtype"] = sc.UNKNOWN_CON
if iscsi.devIsiSCSI(slave):
devInfo["devtype"] = DEV_ISCSI
.....
else:
if devInfo["devtype"] == sc.UNKNOWN_CON:
devInfo["devtype"] = DEV_FCP
That will allow you to remove 279, 358-364
Line 329: pathInfo["type"] = DEV_ISCSI
Line 330: sessionID = iscsi.getiScsiSession(slave)
Line 331: if sessionID not in knownSessions:
Line 332: # FIXME: This entire part is for BC. It should be moved to
--
To view, visit
http://gerrit.ovirt.org/13363
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes