Nir Soffer has posted comments on this change.
Change subject: vdsm.spec: change 'make check' to 'make unittest'
......................................................................
Patch Set 3:
(5 comments)
https://gerrit.ovirt.org/#/c/59417/3//COMMIT_MSG
Commit Message:
Line 3: AuthorDate: 2016-06-18 21:30:59 +0300
Line 4: Commit: Irit Goihman <igoihman(a)redhat.com>
Line 5: CommitDate: 2016-06-27 16:52:11 +0300
Line 6:
Line 7: vdsm.spec: change 'make check' to 'make unittest'
We are not replacing make check, but adding a new target that it depend on.
Line 8:
Line 9: during vdsm rpm check 'make check' is running style validation
Line 10: using tox.
Line 11: not all machines support tox and there are some issues
https://gerrit.ovirt.org/#/c/59417/3/Makefile.am
File Makefile.am:
Line 105
Line 106
Line 107
Line 108
Line 109
This target should depend on unittests.
Since we don't need recursive checks, we can rename it to "check". Hopefully
it will override autoconf recursive check.
Line 88: if [ -n "$(TOX)" ]; then \
Line 89: tox -- pyflakes; \
Line 90: else \
Line 91: echo "Warning: tox is not installed, skipping check"; \
Line 92: fi \
Not related to adding the new target.
Line 93: fi
Line 94:
Line 95: .PHONY: pep8
Line 96: pep8:
Line 100: if [ -n "$(TOX)" ]; then \
Line 101: tox -- pep8; \
Line 102: else \
Line 103: echo "Warning: tox is not installed, skipping check"; \
Line 104: fi \
Not related to adding the new target.
Line 105: fi
Line 106:
Line 107: .PHONY: python3
Line 108: python3: all
Line 125: $(MAKE) -C tests/ check args='-a type=unit'
Line 126:
Line 127: .PHONY: unittest
Line 128: unittest:
Line 129: $(MAKE) -C tests/ check
Looks fine if we can override check in this makefile so it does not run recursive check on
all directories.
Line 130:
Line 131: all-local: \
Line 132: vdsm.spec
Line 133:
--
To view, visit
https://gerrit.ovirt.org/59417
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I378dbf38bbce6cadf87fbedbc9bf6a5d1c714571
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes