Igor Lvovsky has posted comments on this change.
Change subject: Hotplug/Hotunplug disks
......................................................................
Patch Set 2: (7 inline comments)
....................................................
File vdsm/clientIF.py
Line 611: self.vmContainerLock.acquire()
Actually we don't need it at all
Line 613: for param in ('vmId', 'drives'):
Done
....................................................
File vdsm/libvirtvm.py
Line 1078: def _validateDiskParams(self, diskParams):
Done
Line 1112: self._getUnderlyingDriveInfo()
Done
Line 1141: # Find proper drive in _preparedDrives dictionary and torn it
down.
Done
....................................................
File vdsm/vm.py
Line 404: return d
Done
Line 409: drive['index'] = idx
Done
--
To view, visit
http://gerrit.ovirt.org/409
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5feefdba390c4b885aaa5e61f40410419acb3b3c
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>