Dan Kenigsberg has submitted this change and it was merged.
Change subject: BZ#754445 - Separate granting from callback emitting
......................................................................
BZ#754445 - Separate granting from callback emitting
Granting has to happen inside the request transaction to prevent races
with cancel\timeouts. The callback is code that the subsystem does not
know anything about. For that reason it is crucial to run the callback
outside of the lock scope. To keep both demands I split up emit() from
grant().
Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b
---
M vdsm/storage/resourceManager.py
1 file changed, 23 insertions(+), 23 deletions(-)
Approvals:
Dan Kenigsberg: Verified; Looks good to me, approved
--
To view, visit
http://gerrit.ovirt.org/254
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: merged
Gerrit-Change-Id: Ic12d170e64399e37a555960c03804778ad7d053b
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>