Ala Hino has posted comments on this change.
Change subject: Live Merge: Restore watermark tracking
......................................................................
Patch Set 3:
(6 comments)
https://gerrit.ovirt.org/#/c/60889/3/vdsm/virt/vm.py
File vdsm/virt/vm.py:
PS3, Line 928: else:
A single vm drive could require extensions to a merging volume and
the leaf
Done
PS3, Line 961: blockDev
Should this be drive.chuncked?
Done
PS3, Line 984: if volInfo['format'].lower() != 'cow':
: continue
using drive.chuncked above may mitigate the need for this check.
removed
PS3, Line 1008: vol_uuid = os.path.basename(path)
This is not allowed in virt code. We should either add a helper in
HSM to
Done
PS3, Line 4738: maxAlloc = 1
This isn't quite right. self.extendDriveVolume expects a unit in
bytes for
Done
PS3, Line 4740: if drive.imageID in candidates.keys():
: mergeCandidate = candidates[drive.imageID]
: maxAlloc = mergeCandidate['alloc']
This would look nicer as a try/except block:
Done
--
To view, visit
https://gerrit.ovirt.org/60889
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I52199bb38a2d3f439d33b9e78743c3e611349672
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Ala Hino <ahino(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes