Eduardo has posted comments on this change.
Change subject: multipath: Remove unused 'deduceType'
......................................................................
Patch Set 1: I would prefer that you didn't submit this
I like this patch but since DEV_MIXED is not set, I will like if you remove it with all
the associated logic.
$ git gr DEV_MIXED ovirt/master
ovirt/master:vdsm/storage/hsm.py:2784: elif (vgType != multipath.DEV_MIXED
and
ovirt/master:vdsm/storage/hsm.py:2786: vgType = multipath.DEV_MIXED
ovirt/master:vdsm/storage/multipath.py:43:DEV_MIXED = "MIXED"
ovirt/master:vdsm/storage/multipath.py:191: return DEV_MIXED
ovirt/master:vdsm/storage/multipath.py:366: elif (devInfo["devtype"]
!= DEV_MIXED and
ovirt/master:vdsm/storage/multipath.py:368: devInfo["devtype"] ==
DEV_MIXED
ovirt/master:vdsm/storage/multipath.py:430: return type in [DEV_ISCSI, DEV_MIXED]
ovirt/master:vdsm/storage/multipath.py:434: return type in [DEV_FCP, DEV_MIXED]
--
To view, visit
http://gerrit.ovirt.org/13363
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I37a94c3d67641f1c78d8fbecd63cbf1480c6e1b0
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server