Yeela Kaplan has posted comments on this change.
Change subject: [WIP] Reduce the number of pvs calls using lvm.checkpvsblksize()
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/blockSD.py
Line 510: numOfPVs = len(pvs)
Line 511: if version in VERS_METADATA_LV and numOfPVs > MAX_PVS:
Line 512: cls.log.debug("%d > %d", numOfPVs, MAX_PVS)
Line 513: raise se.StorageDomainIsMadeFromTooManyPVs()
Line 514: logBlkSize, phyBlkSize = lvm.checkpvsblksize(pvs)
Did you mean lvm._checkpvsblksize()?
Anyway,
the fix should be actualy changing the name of the function so it won't be
"private".
Line 515:
Line 516: # Create metadata service volume
Line 517: metasize = metaSize(vgName)
Line 518: lvm.createLV(vgName, sd.METADATA, "%s" % (metasize))
--
To view, visit
http://gerrit.ovirt.org/11692
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I778a22843392f2b1345718b3c02bd2f12200056b
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server