Nir Soffer has posted comments on this change.
Change subject: volume_artifacts: Add qcow2_compat on create.
......................................................................
Patch Set 6:
(1 comment)
https://gerrit.ovirt.org/#/c/64372/6/vdsm/storage/sdm/volume_artifacts.py
File vdsm/storage/sdm/volume_artifacts.py:
Line 142:
Line 143: def _initialize_volume(self, vol_format, size):
Line 144: if vol_format == sc.COW_FORMAT:
Line 145: qemuimg.create(self.volume_path, size, sc.fmt2str(vol_format),
Line 146: qcow2_compat=self.sd_manifest.qcow2_compat())
You need to add a test to do this change, check the tests for this module.
The test should create a volume with version 4, and verify that the created qcow file is
using compat 1.1.
Line 147:
Line 148:
Line 149: class FileVolumeArtifacts(VolumeArtifacts):
Line 150: """
--
To view, visit
https://gerrit.ovirt.org/64372
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2dd2d53fba0dd69cdb4f60e152cf6d254cfb863a
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes