Royce Lv has posted comments on this change.
Change subject: Add the REST API bindings
......................................................................
Patch Set 2: (2 inline comments)
nit bugs as I mentioned in the inline comments,other parts looks good to me.
....................................................
File vdsm/rest/Controller.py
Line 608: raise cherrypy.HTTPRedirect(url, 303)
After format 303 redirect to /storagedomains/uuid/ will result in 404 error,it will fail
format operation,we can return 204 instead.
Line 837: pool.obj._UUID, 303)
Same as this place,redirect will return 404 because storage pool is not connected,so we
can't get back pool definition,here
--
To view, visit
http://gerrit.ovirt.org/2021
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b914f7ad82fee8d9e7e3ce6847ffe4cda374a56
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Royce Lv <lvroyce(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Wenchao Xia <xiawenc(a)linux.vnet.ibm.com>