Igor Lvovsky has posted comments on this change.
Change subject: BZ#800915 - no need to support list in removeVM command
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(3 inline comments)
Just minor comments
....................................................
File vdsm/storage/hsm.py
Line 1099: :type vmList: list
Fix this one too
Line 1111: pool.removeVM(vmUUID, sdUUID)
please, keep the key=value style
....................................................
File vdsm/storage/sp.py
Line 1225: self.log.info("spUUID=%s vmUUID=%s sdUUID=%s", self.spUUID,
str(vmUUID), sdUUID)
you don't need str() here
--
To view, visit
http://gerrit.ovirt.org/2694
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4a0e5848ece1aa147f4508d4d16842bcdb30af0d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Haim Ateya <hateya(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Michael Kublin <mkublin(a)redhat.com>