Martin Polednik has posted comments on this change.
Change subject: vmxml: export container metadata
......................................................................
Patch Set 30:
(1 comment)
(quite important) question only, otherwise good to go
https://gerrit.ovirt.org/#/c/60481/30/vdsm/virt/vmxml.py
File vdsm/virt/vmxml.py:
PS30, Line 272: cont = Element(
: xmlcont.METADATA_CONTAINERS_PREFIX + ':' +
: xmlcont.METADATA_CONTAINERS_ELEMENT,
: text=container_type
:
Isn't containerImage required?
--
To view, visit
https://gerrit.ovirt.org/60481
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I1ade3c0c7d300c5ce33cb23723c3d0e59e4af664
Gerrit-PatchSet: 30
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes