Saggi Mizrahi has posted comments on this change.
Change subject: raise ongoing creations count
......................................................................
Patch Set 1: (2 inline comments)
....................................................
File vdsm/vm.py
Line 267: _ongoingCreations = threading.BoundedSemaphore(10)
I know this is why I put it in the end. But we've been running 100 VMs at a time and
it appears to work. Anyway I don't care if this don't get pushed in. It will just
make vm startup slower but will not hinder functionality.
Line 267: _ongoingCreations = threading.BoundedSemaphore(10)
I really don't know, this lock is actually in the wrong place as is. I just changed it
so we could do it as running a 1000 VMs 1 at a time is a lot slower with the 1 limit. It
worked for us. I don't really know the limit is here. Just thought I'd suggest the
fix.
--
To view, visit
http://gerrit.ovirt.org/679
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I83b4f956619ee6cdfde5fdbec9d52484c355b33f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>