Igor Lvovsky has posted comments on this change.
Change subject: API: Provide a working getAllTasks API
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
Only minor comment inside.
In generally as I remember the previous behaviour was:
1. poll the tasks statuses with getAllTaskStatuses because it's cheap
2. only if task finished/failed call getAllTaskInlfo
Now you will call a new getAllTasks every time that is pretty expensive
....................................................
File vdsm/storage/task.py
Line 1282:
what about task id?
--
To view, visit
http://gerrit.ovirt.org/3613
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I43371d358dfdfcfcee14aca40ed06d63be7c0a44
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Doron Fediuck <dfediuck(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: Shireesh Anjal <sanjal(a)redhat.com>