Tomas Golembiovsky has posted comments on this change.
Change subject: v2v: Log detailed output of virt-v2v
......................................................................
Patch Set 6:
(3 comments)
https://gerrit.ovirt.org/#/c/59834/4//COMMIT_MSG
Commit Message:
Line 13: It would be cleaner to modify execCmd() to store the log output, but
Line 14: this can dangerous without the function being refactored first.
Line 15: Therefore we resort to a dirty hack with shell to redirect stderr to
Line 16: stdout and store everything in a log file. This hack should be cleaned
Line 17: once execCmd() is updated.
1. agreed. Do we have a BZ about this? just for tracking purposes (we
could
I don't know about any BZ. I'll try to find out or create a new one,
if there is none yet.
Yes, you get it right. I don't know how we could possibly merge the two together after
the process finishes. And yes, when the command being executed is written to stdout and
the error it produced goes to stderr we lose the connection. We can only guess the the
error in stderr belongs to the last command we see in stdout.
Here is the stdout:
https://paste.fedoraproject.org/389824/82285371/
And here is part of the error stderr:
https://paste.fedoraproject.org/389835/68229240/
Line 18:
Line 19: Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Line 20: Bug-Url:
https://bugzilla.redhat.com/1350465
https://gerrit.ovirt.org/#/c/59834/6/lib/vdsm/v2v.py
File lib/vdsm/v2v.py:
PS6, Line 399: # XXX: This is a rather hacky way to redirect stderr to stdout. It
: # should be rewritten once execCmd has some clean way to do that.
ybronhei suggested to use watchCmd. Perhaps it could help. Did you
tried it
I'm still not sure how is it supposed to help me. I can run async
proces directly with execCmd and I don't need a stop condition. Is there anythin
I'm missing?
PS6, Line 855: ln = self._stream.__iter__().next()
why not
Oh, right! I will fix that in next PS.
--
To view, visit
https://gerrit.ovirt.org/59834
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I6a8d9284316a551edeaffdd66dfcd299fa02478e
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Martin Polednik <mpolednik(a)redhat.com>
Gerrit-Reviewer: Milan Zamazal <mzamazal(a)redhat.com>
Gerrit-Reviewer: Shahar Havivi <shavivi(a)redhat.com>
Gerrit-Reviewer: Tomas Golembiovsky <tgolembi(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes