Saggi Mizrahi has posted comments on this change.
Change subject: Orthogonal storage repository conversion
......................................................................
Patch Set 8: (4 inline comments)
....................................................
Commit Message
Line 7: Orthogonal storage repository conversion
You don't have to be the class or inherit from it to convert. You can be a completely
unrelated class and still covert. Also it's makes all conversion theoretically
possible instead of only "upgrading"
It make conversion simpler cause you don't have to worry about the the old object
state after conversion.
You also need this because the new domains will be completely different obejcts.
....................................................
File vdsm/storage/imageRepository/Makefile.am
Line 2: # Copyright 2008-2011 Red Hat, Inc.
Can't a person copy\paste in peace anymore
....................................................
File vdsm/storage/sdc.py
Line 54: return self._impl
It's a rebasing error, I'll take care of that.
....................................................
File vdsm/storage/sd.py
Line 354: return str(self.getVersion())
I don't know how it's going to compare with strings coming from the xmlrpc. It
means everything has to be unicode which is less then intuitive.
--
To view, visit
http://gerrit.ovirt.org/3045
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7f43faaa9578ddafbae8e3aa01c02b1d42b177ab
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>