Change in vdsm[master]: vm: spice support to clipboard copypaste disable

Francesco Romani has posted comments on this change.

Change subject: vm: spice support to clipboard copypaste disable
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.ovirt.org/#/c/22646/3/vdsm/vm.py
File vdsm/vm.py:

Line 1134:             if self.conf.get('spiceSecureChannels'):
Line 1135:                 for channel in
self.conf['spiceSecureChannels'].split(','):
Line 1136:                     graphics.appendChildWithArgs('channel',
name=channel[1:],
Line 1137:                                                  mode='secure')
Line 1138:             if not utils.tobool(self.conf.get('copyPasteEnable',
True)):
>  After __slots__ being merged I was expecting to see this appearing
> there to 
Well the patch was not rebased yet. Will address after rebase.
Line 1139:                 clipboard = XMLElement('clipboard',
copypaste='no')
Line 1140:                 graphics.appendChild(clipboard)
Line 1141: 
Line 1142:             vmc = XMLElement('channel', type='spicevmc')


-- 
To view, visit http://gerrit.ovirt.org/22646
To unsubscribe, visit http://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I1f8195da0c3ba2663027b77ea8a858e5ba17c48e
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com&gt;
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes