Dan Kenigsberg has posted comments on this change.
Change subject: virtEnabledInCpuAndBios: return status/proper msg
......................................................................
Patch Set 3: I would prefer that you didn't submit this
(2 inline comments)
....................................................
File vds_bootstrap/vds_bootstrap.py
Line 280: retCPU, msg = deployUtil.virtEnabledInCpuAndBios()
I still do not like the name of the retCPU variable!
it is not just about cpu!
....................................................
File vdsm_reg/deployUtil.py.in
Line 1303: def virtEnabledInCpuAndBios():
it is not your fault --- since this whole module has this problem --- but this
function's implementation is wrong, and you are not making it better... It wasn't
clear to me on the previous round. sorry.
this library function should NOT swallow all exceptions. and it should not return an
English message. It should return two booleans - about cpu and about bios.
the calling function should convert these booleans to proper strings (you can use a dict
for that), and handle exceptions.
Even if we cannot fix this now, I'd like to make my opinion heard.
--
To view, visit
http://gerrit.ovirt.org/3549
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I3baff7594ad2cfcf4844a30586a2e4a4313a1972
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>