Douglas Schilling Landgraf has posted comments on this change.
Change subject: profiling: Add an application wide profile
......................................................................
Patch Set 9: Code-Review+1
(1 comment)
http://gerrit.ovirt.org/#/c/26113/9/lib/vdsm/profile.py
File lib/vdsm/profile.py:
Line 35: def start():
Line 36: global yappi
Line 37: if is_enabled():
Line 38: logging.debug("Starting profiling")
Line 39: import yappi
The config specify clearly:
I see and assuming this feature is
for developers it's ok. Other approach is not stop vdsm and log a error since profile
is not crucial to make vdsm running.
Line 40: yappi.start()
Line 41:
Line 42:
Line 43: def stop():
--
To view, visit
http://gerrit.ovirt.org/26113
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I523f52c981f7bb34f3168d3117f00ed5eb6962f8
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Douglas Schilling Landgraf <dougsland(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes