Nir Soffer has posted comments on this change.
Change subject: asyncproc: make read synchronous
......................................................................
Patch Set 2:
(2 comments)
Nice - but how errors are handled?
....................................................
Commit Message
Line 6:
Line 7: asyncproc: make read synchronous
Line 8:
Line 9: Buffered reader assumes the stream has been closed if we return an empty
Line 10: string more than a certain amount of times. This makes it so that we
This patch makes...?
Line 11: keep processing the streams until valid input arrives so we never return
Line 12: an empty stream.
Line 13:
Line 14: Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1
Line 8:
Line 9: Buffered reader assumes the stream has been closed if we return an empty
Line 10: string more than a certain amount of times. This makes it so that we
Line 11: keep processing the streams until valid input arrives so we never return
Line 12: an empty stream.
empty string?
Line 13:
Line 14: Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1
--
To view, visit
http://gerrit.ovirt.org/21897
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id406249bfd63f59f273d27614a38a43595f1d7e1
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Barak Azulay <bazulay(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes