Nir Soffer has posted comments on this change.
Change subject: Replace unused getFileList() with more flexible getFileStats()
......................................................................
Patch Set 5: Code-Review+1
(1 comment)
Nice - there is one possible documentation cleanup if you post another version.
....................................................
File vdsm/storage/hsm.py
Line 2238: :param caseSensitive: Enables case-sensitive matching.
Line 2239: :type caseSensitive: bool
Line 2240: :options: ?
Line 2241:
Line 2242: :returns: a dict of all files and statistics matching the pattern.
:returns: file statistics for files matching pattern.
Is more correct. The fact that we return a dict is specified in :rtype: bellow.
Line 2243: :rtype: dict
Line 2244: """
Line 2245: vars.task.setDefaultException(se.GetFileStatsError(sdUUID))
Line 2246: vars.task.getSharedLock(STORAGE, sdUUID)
--
To view, visit
http://gerrit.ovirt.org/20476
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I550827c7b4c7e11fe09e41745fcc9d91249c6c23
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Sergey Gotliv <sgotliv(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes