Dan Kenigsberg has posted comments on this change.
Change subject: BZ#732914 Establish libvirt connection on startup
......................................................................
Patch Set 2: Looks good to me, but someone else must approve
(1 inline comment)
....................................................
File vdsm/clientIF.py
Line 112: self._libvirt = libvirtconnection.get()
but why do you hold self._libvirt? it would work the same without it, since the connection
is cached in libvirtconnection.
--
To view, visit
http://gerrit.usersys.redhat.com/896
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I913acefd3d41bc34e831783687f287d92c7aa282
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>