Change in vdsm[master]: sos: replace dumpStorageTable with dump_volume_chains

[Code Review]

From Yaniv Bronhaim <ybronhei(a)redhat.com&gt;:

Yaniv Bronhaim has posted comments on this change.

Change subject: sos: replace dumpStorageTable with dump_volume_chains
......................................................................


Patch Set 9:

(1 comment)

https://gerrit.ovirt.org/#/c/62628/9/vdsm/sos/vdsm.py.in
File vdsm/sos/vdsm.py.in:

Line 156: 
Line 157:             sd_uuids = cli.Host.getStorageDomains()
Line 158: 
Line 159:         for sd_uuid in sd_uuids:
Line 160:             self.collectExtOutput("vdsm-tool dump-volume-chains %s" %
sd_uuid)
is this a new thing? the patch should be only like 157. this should be separated I guess
Line 161: 
Line 162:     def _addVdsmRunDir(self):
Line 163:         """Add everything under /var/run/vdsm except possibly
confidential
Line 164:         sysprep vfds and sockets"""


-- 
To view, visit https://gerrit.ovirt.org/62628
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I73a85e6e720b61da1673af7161a21589ade79831
Gerrit-PatchSet: 9
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Irit Goihman <igoihman(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Marina Kalinin <mku(a)redhat.com&gt;
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Oved Ourfali <oourfali(a)redhat.com&gt;
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com&gt;
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes