Dan Kenigsberg has posted comments on this change.
Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs
......................................................................
Patch Set 6: (1 inline comment)
....................................................
File vdsm/alignmentScan.py
Line 56: out_list = [ScanOutput(*line.split(None, 3)) for line in out]
ahhh, I see that my comment here was lost somehow, sorry! I wonder if there's anyone
reading this comment now...
I was saying that defining a clear and usable binding to the command line is the whole
purpose of this module. partition_start_bytes and partition_alignment are integers for
every user, and alignment_scan_result should probably converted to a boolean, or dropped
altogether, since it can be deduced from partition_alignment.
--
To view, visit
http://gerrit.ovirt.org/2916
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saša Tomić <tomic80(a)gmail.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ewoud Kohl van Wijngaarden <ewoud(a)kohlvanwijngaarden.nl>
Gerrit-Reviewer: Saša Tomić <tomic80(a)gmail.com>