Dan Kenigsberg has posted comments on this change.
Change subject: Add the hostId parameter to reconstructMaster
......................................................................
Patch Set 12: I would prefer that you didn't submit this
(2 inline comments)
Federico, I know these patches sit for so long, but I think they deserve a real review
from *someone*.
....................................................
Commit Message
Line 7: Add the hostId parameter to reconstructMaster
what is the motivation for this patch?
....................................................
File vdsm/storage/hsm.py
Line 1448: ioOpTimeoutSec=None, leaseRetries=None, hostId=None,
wouldn't this change draw the universe to its end?
i.e., is the "options" arg has never ever been used by anyone?
--
To view, visit
http://gerrit.ovirt.org/5068
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If665af4ed8be9b5b53dffc7e1fc258b818bf7f98
Gerrit-PatchSet: 12
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Maor Lipchuk <mlipchuk(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>