Saša Tomić has posted comments on this change.
Change subject: Added VDSM interface for the virt-alignment-scan tool from libguestfs ......................................................................
Patch Set 2: (4 inline comments)
.................................................... File vdsm/alignmentScan.py Line 27: cmd.extend(args) although there's no performance difference in this case, it's 1 line less, so I fully agree
Line 48: out_list = [(a[0], a[1], a[2], " ".join(a[3:])) for a in out_list] Nice! I didn't know that you can limit the number of splits. Thanks!
.................................................... File vdsm/alignmentScan_test.py Line 1: #!/usr/bin/python I moved it there. I now hope that there won't be any objections on the performance.
Line 51: img = tempfile.mkstemp()[1] Done
-- To view, visit http://gerrit.ovirt.org/2916 To unsubscribe, visit http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment Gerrit-Change-Id: I2d2c146a0fa3101317720f2e9c373e0d21b5cfdf Gerrit-PatchSet: 2 Gerrit-Project: vdsm Gerrit-Branch: master Gerrit-Owner: Saša Tomić tomic80@gmail.com Gerrit-Reviewer: Dan Kenigsberg danken@redhat.com Gerrit-Reviewer: Ewoud Kohl van Wijngaarden ewoud@kohlvanwijngaarden.nl Gerrit-Reviewer: Saša Tomić tomic80@gmail.com