Dan Kenigsberg has posted comments on this change.
Change subject: vdsm: extract arch-dependent details
......................................................................
Patch Set 2:
(1 comment)
right - we need to wait until safelease.rpm exists.
http://gerrit.ovirt.org/#/c/31297/2/vdsm/storage/protect/spmprotect.sh
File vdsm/storage/protect/spmprotect.sh:
Line 23:
Line 24: SETSID="/usr/bin/setsid"
Line 25: LOGFILE="/var/log/vdsm/spm-lock.log"
Line 26: VDS_CLIENT="/usr/bin/vdsClient"
Line 27: LEASE_UTIL="../safelease/safelease"
I think that an absolution path makes more sense when the binary is external to the
project.
Line 28: KILL="/bin/kill"
Line 29: PKILL="/usr/bin/pkill"
Line 30: sdUUID=$2
Line 31: CHECKVDSM=${CHECKVDSM:-"/usr/bin/pgrep vdsm"}
--
To view, visit
http://gerrit.ovirt.org/31297
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I94bfc8f9d93d8f7a73e69b9390329c342f2904e7
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Yoav Kleinberger <ykleinbe(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes