Yeela Kaplan has posted comments on this change.
Change subject: Fix getStorageDomainInfo() logic.
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
Just need to make one minor change, other than that it's great.
....................................................
File vdsm/storage/hsm.py
Line 2672: "attached to any pool", sdUUID,
exc_info=True)
Line 2673: except se.StoragePoolUnknown:
Line 2674: self.log.error("Domain %s, marked as master, is attached
to "
Line 2675: "pool %s but this host is connected to pool
%s",
Line 2676: sdUUID, pool.spUUID)
Remove redundant %s (3 instead of 2...)
"Domain %s, marked as master, is attached to pool %s but host is not connected to
pool"
Line 2677: else:
Line 2678: # make sure it's THE master of this pool
Line 2679: if pool.masterDomain.sdUUID != sdUUID:
Line 2680: self.log.error("Domain %s is marked as master but
actual "
--
To view, visit
http://gerrit.ovirt.org/14671
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I8b0b2ad3dca19cf203d937c1a9f6a12ab0f1095f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Paikov <paikov(a)gmail.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: oVirt Jenkins CI Server