Nir Soffer has posted comments on this change.
Change subject: stomp: broken unsubscribe process
......................................................................
Patch Set 1:
(1 comment)
https://gerrit.ovirt.org/#/c/45617/1/lib/yajsonrpc/stompreactor.py
File lib/yajsonrpc/stompreactor.py:
Line 281: def is_closed(self):
Line 282: return not self._dispatcher.connected
Line 283:
Line 284: def unsubscribe(self, sub):
Line 285: pass
Why this class need default empty implementation? I don't see any other mention of
subscriptions handling here.
Line 286:
Line 287:
Line 288: class StompServer(object):
Line 289: log = logging.getLogger("yajsonrpc.StompServer")
--
To view, visit
https://gerrit.ovirt.org/45617
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I45c5741f4d94b7af138e98661cfe418cbb0a2b6b
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yaniv Bronhaim <ybronhei(a)redhat.com>
Gerrit-Reviewer: Yeela Kaplan <ykaplan(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes