Federico Simoncelli has posted comments on this change.
Change subject: core: fixing attribute error on fenceSpmStorage
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
Looks ok. I am not confident enough for a +2 today yet.
http://gerrit.ovirt.org/#/c/26358/2/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 3532: if isinstance(pool.getBackend(), StoragePoolDiskBackend):
Line 3533: pool.getBackend().invalidateMetadata()
Line 3534: vars.task.getExclusiveLock(STORAGE, spUUID)
Line 3535: pool.getBackend().forceFreeSpm()
Line 3536: return dict(spm_st=self._getSpmStatusInfo(pool))
Can you double check what engine is going to do with this data? Anyway it's not
relevant for the vote on this patch.
Line 3537:
Line 3538: @public
Line 3539: def upgradeStoragePool(self, spUUID, targetDomVersion):
Line 3540: targetDomVersion = int(targetDomVersion)
--
To view, visit
http://gerrit.ovirt.org/26358
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5ae4c371e2dc97686621ea16b8cef971183a6ab2
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Liron Ar <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes