Piotr Kliczewski has posted comments on this change.
Change subject: vdsm: removing txRate and rxRate from code
......................................................................
Patch Set 5: Code-Review-1
I like patches like that but I checked engine 4.0 and i see that this information is
parsed by VdsBrokerObjectsBuilder#extractInterfaceStatistics and later it is stored in
vds_interface_statistics. Looking further I see that this information is returned by
engine rest api and referenced in the UI. Are we sure this is not breaking change?
-1 for visibility, I will remove once we know we do not break backward compatibility
--
To view, visit
https://gerrit.ovirt.org/59544
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Id6466de88f0228ac3496b4642d34f5eb7b281afa
Gerrit-PatchSet: 5
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Marcin Mirecki <mmirecki(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Yevgeny Zaspitsky <yzaspits(a)redhat.com>
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: No