Change in vdsm[master]: netlink: monitor: join scanner thread on __exit__

[Code Review]

From Dan Kenigsberg <danken(a)redhat.com&gt;:

Dan Kenigsberg has posted comments on this change.

Change subject: netlink: monitor: join scanner thread on __exit__
......................................................................


Patch Set 3: Code-Review-1

(2 comments)

https://gerrit.ovirt.org/#/c/69041/3//COMMIT_MSG
Commit Message:

PS3, Line 17: with --countthreads
the plugin was renamed --with-thread-leak-check


https://gerrit.ovirt.org/#/c/69041/3/lib/vdsm/network/netlink/monitor.py
File lib/vdsm/network/netlink/monitor.py:

Line 173:     def is_stopped(self):
Line 174:         return self._scanning_stopped.is_set()
Line 175: 
Line 176:     def wait(self, timeout=None):
Line 177:         if timeout:
I think you can copy timeout blindly.

you current code blocks forever if timeout=0.
Line 178:             self._scan_thread.join(timeout)
Line 179:         else:
Line 180:             self._scan_thread.join()
Line 181: 


-- 
To view, visit https://gerrit.ovirt.org/69041
To unsubscribe, visit https://gerrit.ovirt.org/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: I9dd0097ad8d6ba5288e27b8f02bc62fc562030e9
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Edward Haas <edwardh(a)redhat.com&gt;
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com&gt;
Gerrit-Reviewer: Petr Horáček <phoracek(a)redhat.com&gt;
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org&gt;
Gerrit-HasComments: Yes