Change in vdsm[master]: Handle EAGAIN and EINTR in ProcessPool.runExternally

Saggi Mizrahi has posted comments on this change.

Change subject: Handle EAGAIN and EINTR in ProcessPool.runExternally
......................................................................


Patch Set 1: I would prefer that you didn't submit this

(1 inline comment)

Dan, is right. Though a bit unrelated a patch that handles all exceptions in poll would
have been better.

....................................................
File vdsm/storage/processPool.py
Line 138:             end_time = time.time() + self.timeout
Line 139: 
Line 140:             while time.time() < end_time:
Line 141:                 try:
Line 142:                     pollres = helper.pipe.poll(self.timeout)
helper.pipe.poll(end_time - time.time())
Line 143:                 except (OSError, IOError) as e:
Line 144:                     if not e.errno in (errno.EINTR, errno.EAGAIN):
Line 145:                         raise
Line 146: 


--
To view, visit http://gerrit.usersys.redhat.com/1051
To unsubscribe, visit http://gerrit.usersys.redhat.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: Id1d0f35af9db6e237c87b00438b9ce3ded9faa8f
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com&gt;
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com&gt;
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com&gt;