Francesco Romani has posted comments on this change.
Change subject: vm.py: State saving in hotunplugDisk.
......................................................................
Patch Set 6: Code-Review+1
(1 comment)
preliminary ACK. At glance patch looks OK, and code is nicer and shorter - and less
fragile.
Deeper review later.
https://gerrit.ovirt.org/#/c/45077/6/vdsm/virt/vm.py
File vdsm/virt/vm.py:
Line 2642:
Line 2643: self.saveState()
Line 2644: hooks.after_disk_hotunplug(driveXml, self.conf,
Line 2645: params=drive.custom)
Line 2646:
unrelated, but I don't mind that much.
Line 2647: self._cleanupDrives(drive)
Line 2648:
Line 2649: return {'status': doneCode, 'vmList': self.status()}
Line 2650:
--
To view, visit
https://gerrit.ovirt.org/45077
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I2cf18186cbba33d7e74fd15651ffec3149c98e1d
Gerrit-PatchSet: 6
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Allon Mureinik <amureini(a)redhat.com>
Gerrit-Reviewer: Amit Aviram <aaviram(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Liron Aravot <laravot(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes