Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 32:
(3 comments)
very partial review
http://gerrit.ovirt.org/#/c/24456/32/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 43: from .ipwrapper import Route
Line 44: from .ipwrapper import routeGet
Line 45: from .ipwrapper import routeShowGateways, routeShowAllDefaultGateways
Line 46: from . import libvirtconnection
Line 47: from .utils import execCmd, memoized, CommandPath
.utils should come after .netlink ( alphabetically)
Line 48: from .netconfpersistence import RunningConfig
Line 49: from .netlink import iter_addrs, iter_links
Line 50:
Line 51:
Line 535: return ''.join(random.choice(CHARS) for _ in range(MAX_LENGTH))
Line 536:
Line 537:
Line 538: @memoized
Line 539: def _getDefaultBondingOptions():
This function still misses a docstring explained king its return value.
Line 540: teeCmd = _TEE_BINARY.cmd
Line 541: MAX_MODE = 6
Line 542:
Line 543: bondName = _randomIfaceName()
Line 593: Options having symbolic values, e.g. 'mode', are presented by sysfs
in
Line 594: the order symbolic name, numeric value, e.g. 'balance-rr 0'.
Line 595: From a list given by bondOpts(), the numeric value is chosen.
Line 596:
Line 597: 'mode' is ordered the first so e.g. iproute2 configurator sets it
first.
Iproute2 configurator should be fixed to take "mode" first. (in a separate
patch!)
Line 598: '''
Line 599: mode = opts.pop('mode', None)
Line 600: ifcfg = sorted(opts.iteritems())
Line 601: if mode:
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 32
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes