Mark Wu has posted comments on this change.
Change subject: hotunplug: identify a nic according to its alias
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/vm.py
Line 3057:
Line 3058: # Find NIC object in vm's NICs list
Line 3059: nic = None
Line 3060: for dev in self._devices[NIC_DEVICES][:]:
Line 3061: if (dev.alias == nicParams.get('alias') or
is 'alias' optional in the nicParams? it's not optional according to the
definition of VmInterfaceDevice in vdsmapi-schema.json
Line 3062: dev.macAddr.lower() ==
nicParams['macAddr'].lower()):
Line 3063: nic = dev
Line 3064: break
Line 3065:
--
To view, visit
http://gerrit.ovirt.org/12892
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iae7619c2547d667103e33777180e01b285f4b18d
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Mark Wu <wudxw(a)linux.vnet.ibm.com>
Gerrit-Reviewer: oVirt Jenkins CI Server