Dan Kenigsberg has posted comments on this change.
Change subject: relax the validation multiple networks on the same interface
......................................................................
Patch Set 3:
(1 comment)
http://gerrit.ovirt.org/#/c/34538/3/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 786: for interface in netdict['ports']:
Line 787: if iface == interface:
Line 788: yield (network, None)
Line 789: elif interface.startswith(iface + '.'):
Line 790: yield (network, int(interface.split('.',
1)[1]))
Please use getVlanID() as the one in line 799.
Line 791:
Line 792: def getBridgelessNetworksAndVlansForIface(self, iface):
Line 793: """ Returns tuples of (network, vlan) connected to
nic/bond """
Line 794: for network, netdict in self.networks.iteritems():
--
To view, visit
http://gerrit.ovirt.org/34538
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I0030433ef519ae6699ee8a921b95c0a67f7b2eae
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ido Barkan <ibarkan(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes