Piotr Kliczewski has posted comments on this change.
Change subject: gluster: Added geo-replication session list and session status
......................................................................
Patch Set 24: Code-Review-1
(2 comments)
http://gerrit.ovirt.org/#/c/18414/24/vdsm/gluster/apiwrapper.py
File vdsm/gluster/apiwrapper.py:
Line 201: return self._gluster.volumeGeoRepSessionStatus(masterVolumeName,
Line 202: remoteHost,
Line 203: remoteVolumeName)
Line 204:
Line 205: def geoRepSessionList(self, masterVolumeName=None, remoteHost=None,
I can see that you specified all parameters optional but I do not see that in schema.
Please make sure that all optional params are in schema as well.
Line 206: remoteVolumeName=None):
Line 207: return self._gluster.volumeGeoRepSessionList(masterVolumeName,
Line 208: remoteHost,
http://gerrit.ovirt.org/#/c/18414/24/vdsm/rpc/vdsmapi-gluster-schema.json
File vdsm/rpc/vdsmapi-gluster-schema.json:
Line 1338: # @geoRepPairInfo:
Line 1339: #
Line 1340: # Gluster geo-replication pair information.
Line 1341: #
Line 1342: # @host: host of the local volume
Please align in line description of each attribute for all newly added types and
commands.
Line 1343: #
Line 1344: # @hostUuid: Uuid of host for local volume brick
Line 1345: #
Line 1346: # @brickName: local volume brick involved in session
--
To view, visit
http://gerrit.ovirt.org/18414
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I4f37f35a5480fbe049a67758e122d4a0c2eba513
Gerrit-PatchSet: 24
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <celebdor(a)gmail.com>
Gerrit-Reviewer: Aravinda VK <avishwan(a)redhat.com>
Gerrit-Reviewer: Bala.FA <barumuga(a)redhat.com>
Gerrit-Reviewer: Better Saggi <bettersaggi(a)gmail.com>
Gerrit-Reviewer: Darshan N <dnarayan(a)redhat.com>
Gerrit-Reviewer: Piotr Kliczewski <piotr.kliczewski(a)gmail.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Sahina Bose <sabose(a)redhat.com>
Gerrit-Reviewer: Timothy Asir <tjeyasin(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: Yes