Ayal Baron has posted comments on this change.
Change subject: Do not use lvm to get lv size if lv is active
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/storage/blockVolume.py
Line 85: if lvm.isLVActive(sdobj.sdUUID, volUUID):
I see no point in going through lvm cache here at all. The positive path is that
we're getting the size because this is a disk that belongs to an active domain so
calling lvm is redundant.
--
To view, visit
http://gerrit.ovirt.org/677
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I5e81bf563f07119a775888d6abc3c81f4f7b86a0
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Saggi Mizrahi <smizrahi(a)redhat.com>
Gerrit-Reviewer: Adam Litke <agl(a)us.ibm.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>