Juan Hernandez has posted comments on this change.
Change subject: BZ#770834 - Handle correctly nic names like p33p1
......................................................................
Patch Set 3: (1 inline comment)
....................................................
File vdsm/configNetwork.py
Line 157: return sorted(nics, key=splitNicForSorting)
I don't see any reason to open a bug on initscripts as I didn't detect any problem
there. The problem was/is in vds_bootstrap.py and ultimately in configNetwork.py.
I don't really know if the correctness of the sort is important. What is really
important is to make sure that no part of the interface name is lost. For that patch set 2
is enough.
--
To view, visit
http://gerrit.ovirt.org/799
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I716f5d7d137325abaa0022a40f482c9ad270855a
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Juan Hernandez <juan.hernandez(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Federico Simoncelli <fsimonce(a)redhat.com>
Gerrit-Reviewer: Juan Hernandez <juan.hernandez(a)redhat.com>