Dan Kenigsberg has posted comments on this change.
Change subject: netinfo: Retrieve bonding options differing from defaults
......................................................................
Patch Set 8: Code-Review-1
(1 comment)
http://gerrit.ovirt.org/#/c/24456/8/lib/vdsm/netinfo.py
File lib/vdsm/netinfo.py:
Line 581: # Actual options in /sys are multi-valued and again, separated by a space,
Line 582: # including 'mode' which reads: 'balance-rr 0'
Line 583: # For compatibility with older Engines we should return 'mode' as a
number
Line 584: # and never handle "other" multi-valued options
Line 585: opts = ' '.join((k + '=' + ','.join(v) for (k, v) in
opts.iteritems()))
How about just:
You should not return dictionary, but a
space-separated string.
Not all opts are as-important, but we should match whatever Engine used to send.
"slaves" should be blacklisted, and maybe others, but in general - please report
anything that differs from the defaults.
Line 586: info['cfg']['BONDING_OPTS'] = opts
Line 587:
Line 588: return info
Line 589:
--
To view, visit
http://gerrit.ovirt.org/24456
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ief6d366b1b761627c7203cf236b75ef538af3e26
Gerrit-PatchSet: 8
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Assaf Muller <amuller(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Ondřej Svoboda <osvoboda(a)redhat.com>
Gerrit-HasComments: Yes