Dan Kenigsberg has posted comments on this change.
Change subject: getDeviceList - passing includePartitioned to HSM
......................................................................
Patch Set 1: I would prefer that you didn't submit this
(1 inline comment)
BTW, I personally do not see a problem in flipping the default of includePartitioned - no
vdsClient user would explode if he finds partitions reported in his output.
....................................................
File vdsm_cli/vdsClient.py
Line 545: params = {'includePartitioned': includePartitioned}
It would be nicer if you used _parseDriveSpec and have the command line look like
getDeviceList <storageType> includePartitioned:True,
also, the second param to getDeviceList is called "options" not
"params".
--
To view, visit
http://gerrit.ovirt.org/4828
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I388442f361ea4ae00e3d8878a2497c7819ab2214
Gerrit-PatchSet: 1
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Ayal Baron <abaron(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Daniel Erez <derez(a)redhat.com>
Gerrit-Reviewer: Eduardo <ewarszaw(a)redhat.com>