Francesco Romani has posted comments on this change.
Change subject: vm: log xml from/to libvirt at 'info' level
......................................................................
Patch Set 3:
added (repetitive) comment to stress out that having xml dump as INFO is a temporary
necessary evil.
This is because getXML may do some non-trivial processing, exspecially for disks and NICs,
so just to have the attribute listing in short format (name1=value1, name2=value2,... )
may not be enough.
Future work is planned to improve this.
--
To view, visit
http://gerrit.ovirt.org/34358
To unsubscribe, visit
http://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia07823512a8cdf5f05789b29bf3d4daa1a8ccb07
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Antoni Segura Puimedon <asegurap(a)redhat.com>
Gerrit-Reviewer: Francesco Romani <fromani(a)redhat.com>
Gerrit-Reviewer: Michal Skrivanek <michal.skrivanek(a)redhat.com>
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: Vinzenz Feenstra <vfeenstr(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-Reviewer: oVirt Jenkins CI Server
Gerrit-HasComments: No