From Dan Kenigsberg <danken(a)redhat.com>:
Dan Kenigsberg has posted comments on this change.
Change subject: storage: move task and taskManager to lib
......................................................................
Patch Set 7:
(1 comment)
https://gerrit.ovirt.org/#/c/69329/7/lib/vdsm/storage/taskManager.py
File lib/vdsm/storage/taskManager.py:
Line 26: from vdsm.config import config
Line 27: from vdsm.storage import exception as se
Line 28: from vdsm.storage.threadPool import ThreadPool
Line 29:
Line 30: from .task import Task, Job, TaskCleanType
Is this considered a relative import? Why not
no good reason,
besides similarity to the existing code. I'll do as you suggest.
Line 31:
Line 32:
Line 33: class TaskManager:
Line 34: log = logging.getLogger('storage.TaskManager')
--
To view, visit
https://gerrit.ovirt.org/69329
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I97890c2600ffd8bfef7b51fdc4457e5b92459164
Gerrit-PatchSet: 7
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Adam Litke <alitke(a)redhat.com>
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: gerrit-hooks <automation(a)ovirt.org>
Gerrit-HasComments: Yes