Eduardo Warszawski has posted comments on this change.
Change subject: BZ#732765 - Don't return empty strings for
'disktotal'/'diskfree' on unreachable domains during getStoragePoolInfo
......................................................................
Patch Set 2: I would prefer that you didn't submit this
(1 inline comment)
....................................................
File vdsm/storage/sp.py
Line 1080: stats.pop('diskfree', None)
If you use pop() with default value None, there is no KeyError.
Remove the case.
This except clause is confuse, why not split the main try clause?
Shorter is better.
--
To view, visit
http://gerrit.usersys.redhat.com/862
To unsubscribe, visit
http://gerrit.usersys.redhat.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I64ae55b4942cf5748d3d8ada445a3381498ea258
Gerrit-PatchSet: 2
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Ayal Baron
Gerrit-Reviewer: Dan Kenigsberg <danken(a)redhat.com>
Gerrit-Reviewer: Eduardo Warszawski <ewarszaw(a)redhat.com>
Gerrit-Reviewer: Igor Lvovsky <ilvovsky(a)redhat.com>
Gerrit-Reviewer: Saggi Mizrahi <smizrahi(a)redhat.com>