Freddy Rolland has posted comments on this change.
Change subject: hsm: Support checkStatus param in getDeviceList
......................................................................
Patch Set 3:
(2 comments)
https://gerrit.ovirt.org/#/c/45093/3/vdsm/storage/hsm.py
File vdsm/storage/hsm.py:
Line 2026
Line 2027
Line 2028
Line 2029
Line 2030
For example, we can add the status here:
Done
Line 2023: pvsize = ""
Line 2024: vguuid = ""
Line 2025:
Line 2026: devInfo = {'GUID': dev.get("guid", ""),
'pvUUID': pvuuid,
Line 2027: 'status': 'unknown',
Correct, but I wonder if we should make it more clear like by adding
"statu
Done
Line 2028: 'pvsize': str(pvsize),
Line 2029: 'vgUUID': vguuid, 'vendorID':
dev.get("vendor", ""),
Line 2030: 'productID': dev.get("product",
""),
Line 2031: 'fwrev': dev.get("fwrev",
""),
--
To view, visit
https://gerrit.ovirt.org/45093
To unsubscribe, visit
https://gerrit.ovirt.org/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ic28954708f2fd7c7b721aa7f9a0fb6e1a6019597
Gerrit-PatchSet: 3
Gerrit-Project: vdsm
Gerrit-Branch: master
Gerrit-Owner: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Fred Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Freddy Rolland <frolland(a)redhat.com>
Gerrit-Reviewer: Jenkins CI
Gerrit-Reviewer: Nir Soffer <nsoffer(a)redhat.com>
Gerrit-Reviewer: automation(a)ovirt.org
Gerrit-HasComments: Yes